Open
Conversation
Removed patch_model for ExprVisitor 1to1 mapping from xmnn-isax-flow/cdsl/top.core_desc to etiss for pre patch_model to current flow
Caution: Most of the transform is generated by Copilot 1to1 mapping from xmnn-isax-flow/cdsl/top.core_desc to etiss for pre patch_model to current flow
Author
|
Update I removed all patch_model() instances and have for an example core no difference in generated etiss code: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial commit and proof of concept aimed at replacing the current patch_model function with an ExprVisitor metaclass that supports overrideable (or optionally enforced) visitor aka generator functions.
The basic patch_model replacement consists of an own Subclass of the ExprVisitor with an own dispatched recursive generate function that differs its behavior regarding its input type (behav.{type}).
Therefore no global shared function set exists anymore. Also non existent generation overloads lead to
an NotImplemented exception -> Improvement of determinism