Modify JSON Tests to allow connection to external server.#70
Merged
Conversation
Signed-off-by: Nikhil Manglore <nmanglor@amazon.com>
Signed-off-by: Nikhil Manglore <nmanglor@amazon.com>
allenss-amazon
pushed a commit
to allenss-amazon/valkeyJSON
that referenced
this pull request
Aug 15, 2025
Signed-off-by: Nikhil Manglore <nmanglor@amazon.com> Signed-off-by: Allen Samuels <allenss@amazon.com>
roshkhatri
added a commit
that referenced
this pull request
Sep 8, 2025
``` ================================================================================ Valkey JSON 1.0.2 - Released Mon 8 September 2025 ================================================================================ * Support building valkey-json on Clang/Apple (#69) * Workdflow to automatically trigger valkey-bundle release (#64) * Allow testing on external container server (#70) * Implement SharedAPI interface that mimics JSON.GET (#71) ```
roshkhatri
pushed a commit
to roshkhatri/valkey-json
that referenced
this pull request
Dec 15, 2025
Signed-off-by: Nikhil Manglore <nmanglor@amazon.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the ability to run tests against an external Valkey server instead of always starting a new one. It coincides with the changes made in the Valkey-Test-Framework (valkey-io/valkey-test-framework#7)
External server mode: If we set the environment variable, `VALKEY_EXTERNAL_SERVER=true , when we run the bloom pytests we will connect to an existing Valkey server at the specified host and port.
Local server mode: If not set or false, we will continue with the original behavior of starting a new Valkey server with the module loaded