ci: add live Docker workbench smoke#424
Merged
Merged
Conversation
vibeforge1111
pushed a commit
that referenced
this pull request
May 27, 2026
Updates docker/live from node:22-bookworm-slim to node:26-bookworm-slim. Required CI, secret scan, CodeQL, Scorecard, and spark-jury-approval passed. Optional Docker workbench was dispatched after #424 added live-image smoke; the affected live-smoke job passed build, CLI help, and fail-closed entrypoint checks. The unrelated dev/sandbox optional jobs exposed separate pre-existing workbench issues and were not used as proof for this live-image-only bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the missing live-image lane to the optional Docker workbench so Docker runtime base-image PRs can be tested symmetrically.\n\nWhy:\n- Existing manual Docker workflow covered dev and sandbox images, but not docker/live.\n- Dependabot PR #255 changes docker/live, so we need a bounded live-image smoke before accepting that runtime bump.\n\nWhat changed:\n- Build docker/live/Dockerfile in .github/workflows/docker-optional.yml.\n- Run spark --help inside the live image as the spark user.\n- Verify the live entrypoint fails closed without hosted env by expecting the SPARK_LLM_PROVIDER guard.\n- Update docs/OPTIONAL_DOCKER_WORKBENCH.md to mention the live image smoke lane.\n\nLocal verification:\n- python -m pytest tests/test_docker_entrypoint.py tests/test_access.py -q -> 24 passed, 4 skipped, 6 subtests passed\n- git diff --check -> OK\n\nNote: Docker daemon is not running on the publishing machine, so the actual Docker build/run proof must come from GitHub workflow_dispatch or the Mac lab.