Avoid infinite placement loop when lineHeight is 0#71
Open
Frenzie wants to merge 1 commit intovideojs:0.15.xfrom
Open
Avoid infinite placement loop when lineHeight is 0#71Frenzie wants to merge 1 commit intovideojs:0.15.xfrom
Frenzie wants to merge 1 commit intovideojs:0.15.xfrom
Conversation
This can happen for empty subtitles.
Frenzie
force-pushed
the
avoid-infinite-placement-loop
branch
from
6d5497a to
8e89a2a
Compare
Frenzie
changed the title
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can happen for empty subtitles.
Intuitively it makes more sense to me to ignore them earlier in the chain, but the tests expect it to exist there, which I suppose makes sense from a VTT parsing perspective.
vtt.js/tests/file-layout/cue-spacing.vtt
Lines 8 to 10 in e9c8ae0
vtt.js/tests/file-layout/cue-spacing.json
Lines 35 to 50 in e9c8ae0