Fix thread-safety issues in VAppearances initialization#11
Open
karlvr wants to merge 1 commit into
Open
Conversation
Make initialize() synchronized to prevent a race condition where multiple threads could trigger double-initialization. Mark isInitialized, isLoaded, isEffectiveAppearanceSupported, and DEBUG_FLAG as volatile to ensure cross-thread visibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm always a bit uncertain about how much thread safety we need in this area, but we've got a lot of
synchronizationaround so I figure we're trying to to it properly.Make
initialize()synchronized to prevent a race condition where multiple threads could trigger double-initialization. MarkisInitialized,isLoaded,isEffectiveAppearanceSupported, andDEBUG_FLAGas volatile to ensure cross-thread visibility.DEBUG_FLAGobviously a critical one ;-)