Skip to content

Fix thread-safety issues in VAppearances initialization #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karlvr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix thread-safety issues in VAppearances initialization #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/org/violetlib/vappearances/VAppearances.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,16 +105,16 @@ private VAppearances()
// public final static @NotNull String highContrastVibrantLightAppearance = "NSAppearanceNameAccessibilityHighContrastVibrantLight";
// public final static @NotNull String highContrastVibrantDarkAppearance = "NSAppearanceNameAccessibilityHighContrastVibrantDark";

private static boolean isInitialized;
private static boolean isLoaded;
private static boolean isEffectiveAppearanceSupported;
private static volatile boolean isInitialized;
private static volatile boolean isLoaded;
private static volatile boolean isEffectiveAppearanceSupported;

/** Keeps the data for known appearances */
private static final @NotNull AppearanceDataCache appearanceDataCache = new AppearanceDataCache();

private static boolean DEBUG_FLAG = false;
private static volatile boolean DEBUG_FLAG = false;

private static void initialize()
private static synchronized void initialize()
{
if (!isInitialized) {
isInitialized = true;
Expand Down