fix(dev-env): strip trailing slash in URLs when doing sync#2329
Merged
sjinks merged 1 commit intoApr 18, 2025
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the URL synchronization by stripping trailing slashes from URLs to ensure consistency between the database and SDS.
- Removed trailing slash from site home URLs in the URL extraction logic.
- Updated the search-replace mapping logic to also remove trailing slashes from URLs.
rinatkhaziev
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR strips the trailing slash from the replaced URLs to ensure that URLs from the database match URLs from the SDS.
See: PLTFRM-361
Pull request checklist
New release checklist
Steps to Test
See PLTFRM-361