Skip to content

fix(dev-env): strip trailing slash in URLs when doing sync#2329

Merged
sjinks merged 1 commit into
trunkfrom
pltfrm-361-local-data-sync-search-replace-map-not-working-on-forward
Apr 18, 2025
Merged

fix(dev-env): strip trailing slash in URLs when doing sync#2329
sjinks merged 1 commit into
trunkfrom
pltfrm-361-local-data-sync-search-replace-map-not-working-on-forward

Conversation

@sjinks
Copy link
Copy Markdown
Member

@sjinks sjinks commented Apr 18, 2025

Description

This PR strips the trailing slash from the replaced URLs to ensure that URLs from the database match URLs from the SDS.

See: PLTFRM-361

Pull request checklist

New release checklist

Steps to Test

See PLTFRM-361

@sjinks sjinks added [Type] Bug Something isn't working [Status] Needs Review labels Apr 18, 2025
@sjinks sjinks self-assigned this Apr 18, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@sonarqubecloud
Copy link
Copy Markdown

@sjinks sjinks requested a review from Copilot April 18, 2025 20:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes the URL synchronization by stripping trailing slashes from URLs to ensure consistency between the database and SDS.

  • Removed trailing slash from site home URLs in the URL extraction logic.
  • Updated the search-replace mapping logic to also remove trailing slashes from URLs.

@sjinks sjinks merged commit ed56908 into trunk Apr 18, 2025
18 checks passed
@sjinks sjinks deleted the pltfrm-361-local-data-sync-search-replace-map-not-working-on-forward branch April 18, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants