Skip to content

fix(dev-env): strip trailing slash in URLs when doing sync #2329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sjinks merged 1 commit into from
Apr 18, 2025
Merged

fix(dev-env): strip trailing slash in URLs when doing sync #2329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/commands/dev-env-sync-sql.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,9 @@ async function extractSiteUrls( sqlFile: string ): Promise< string[] > {
return new Promise( ( resolve, reject ) => {
const urls: Set< string > = new Set();
readInterface.on( 'line', line => {
const url = findSiteHomeUrl( line );
let url = findSiteHomeUrl( line );
if ( url ) {
url = url.replace( /\/$/, '' );
urls.add( url );
}
} );
Expand Down Expand Up @@ -209,7 +210,7 @@ export class DevEnvSyncSQLCommand {
const url = site?.homeUrl;
if ( ! url ) continue;

const strippedUrl = stripProtocol( url );
const strippedUrl = stripProtocol( url ).replace( /\/$/, '' );
if ( ! this.searchReplaceMap[ strippedUrl ] ) continue;

const domain = new URL( url ).hostname;
Expand Down