New Crowdin updates#60
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
There was a problem hiding this comment.
Pull Request Overview
Crowdin import updating localization files with new ERC-20 approval flow strings and metadata.
- Update PO-Revision-Date in ru-RU and es-ES files
- Add new msgids for ERC20 approval UI/flows; several include placeholders and user-facing messages
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| apps/cowswap-frontend/src/locales/ru-RU.po | Adds new ERC20 approval-related strings to Russian locale and updates revision date. |
| apps/cowswap-frontend/src/locales/es-ES.po | Adds new ERC20 approval-related strings to Spanish locale and updates revision date. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
apps/cowswap-frontend/src/locales/ru-RU.po:1
- The translation omits 'amount'; use 'Сумма одобрения:'.
msgid ""
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| msgid "Partial approval may block <0>{ordersWithPermitLenght}</0> other orders" | ||
| msgstr "La aprobación parcial puede bloquear <0>{ordersWithPermitLenght}</0> otros pedidos" |
There was a problem hiding this comment.
Change ordersWithPermitLenght to ordersWithPermitLength in both msgid and msgstr; otherwise the placeholder will not be substituted.
| msgid "Partial approval may block <0>{ordersWithPermitLenght}</0> other orders" | |
| msgstr "La aprobación parcial puede bloquear <0>{ordersWithPermitLenght}</0> otros pedidos" | |
| msgid "Partial approval may block <0>{ordersWithPermitLength}</0> other orders" | |
| msgstr "La aprobación parcial puede bloquear <0>{ordersWithPermitLength}</0> otros pedidos" |
| msgid "Amount must be at least trade amount" | ||
| msgstr "Amount must be at least trade amount" |
There was a problem hiding this comment.
The message reads awkwardly; consider 'Amount must be at least the trade amount' for clarity. Update the source string in code and re-extract so translations can be updated accordingly.
| msgid "Amount must be at least trade amount" | |
| msgstr "Amount must be at least trade amount" | |
| msgid "Amount must be at least the trade amount" | |
| msgstr "Amount must be at least the trade amount" |
4d2ffa5
into
feat/internationalization-setup-for-swap-cow-fi
No description provided.