Skip to content

New Crowdin updates#60

Merged
gabitoesmiapodo merged 6 commits into
feat/internationalization-setup-for-swap-cow-fifrom
l10n_feat/internationalization-setup-for-swap-cow-fi
Oct 16, 2025
Merged

New Crowdin updates#60
gabitoesmiapodo merged 6 commits into
feat/internationalization-setup-for-swap-cow-fifrom
l10n_feat/internationalization-setup-for-swap-cow-fi

Conversation

@gabitoesmiapodo
Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings October 16, 2025 18:36
@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cowswap Ready Ready Preview Comment Oct 16, 2025 6:51pm

@github-actions
Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Crowdin import updating localization files with new ERC-20 approval flow strings and metadata.

  • Update PO-Revision-Date in ru-RU and es-ES files
  • Add new msgids for ERC20 approval UI/flows; several include placeholders and user-facing messages

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
apps/cowswap-frontend/src/locales/ru-RU.po Adds new ERC20 approval-related strings to Russian locale and updates revision date.
apps/cowswap-frontend/src/locales/es-ES.po Adds new ERC20 approval-related strings to Spanish locale and updates revision date.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread apps/cowswap-frontend/src/locales/ru-RU.po
Comment thread apps/cowswap-frontend/src/locales/es-ES.po
Comment thread apps/cowswap-frontend/src/locales/ru-RU.po
Comment thread apps/cowswap-frontend/src/locales/es-ES.po
Comment thread apps/cowswap-frontend/src/locales/ru-RU.po Outdated
Comment thread apps/cowswap-frontend/src/locales/es-ES.po Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread apps/cowswap-frontend/src/locales/en-US.po
Comment thread apps/cowswap-frontend/src/locales/es-ES.po
Comment thread apps/cowswap-frontend/src/locales/ru-RU.po
Comment thread apps/cowswap-frontend/src/locales/ru-RU.po Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

apps/cowswap-frontend/src/locales/ru-RU.po:1

  • The translation omits 'amount'; use 'Сумма одобрения:'.
msgid ""

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread apps/cowswap-frontend/src/locales/en-US.po
Comment on lines +990 to +991
msgid "Partial approval may block <0>{ordersWithPermitLenght}</0> other orders"
msgstr "La aprobación parcial puede bloquear <0>{ordersWithPermitLenght}</0> otros pedidos"
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change ordersWithPermitLenght to ordersWithPermitLength in both msgid and msgstr; otherwise the placeholder will not be substituted.

Suggested change
msgid "Partial approval may block <0>{ordersWithPermitLenght}</0> other orders"
msgstr "La aprobación parcial puede bloquear <0>{ordersWithPermitLenght}</0> otros pedidos"
msgid "Partial approval may block <0>{ordersWithPermitLength}</0> other orders"
msgstr "La aprobación parcial puede bloquear <0>{ordersWithPermitLength}</0> otros pedidos"

Copilot uses AI. Check for mistakes.
Comment thread apps/cowswap-frontend/src/locales/ru-RU.po
Comment on lines +2382 to +2383
msgid "Amount must be at least trade amount"
msgstr "Amount must be at least trade amount"
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message reads awkwardly; consider 'Amount must be at least the trade amount' for clarity. Update the source string in code and re-extract so translations can be updated accordingly.

Suggested change
msgid "Amount must be at least trade amount"
msgstr "Amount must be at least trade amount"
msgid "Amount must be at least the trade amount"
msgstr "Amount must be at least the trade amount"

Copilot uses AI. Check for mistakes.
Comment thread apps/cowswap-frontend/src/locales/ru-RU.po
@gabitoesmiapodo gabitoesmiapodo merged commit 4d2ffa5 into feat/internationalization-setup-for-swap-cow-fi Oct 16, 2025
4 of 7 checks passed
@gabitoesmiapodo gabitoesmiapodo deleted the l10n_feat/internationalization-setup-for-swap-cow-fi branch October 16, 2025 18:59
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants