fix: always write -latest.json even when no new deployments occur#2
Merged
fix: always write -latest.json even when no new deployments occur#2
Conversation
When a CI run is interrupted after contracts are deployed on-chain but before deployment JSON files are written, a retry run detects the existing contracts and skips redeployment. However, _hasNewDeployments remains false, causing _afterAll() to skip writing all JSON files — including the cumulative -latest.json that already has the correct data in memory. Decouple -latest.json persistence from the _hasNewDeployments flag so the cumulative file is always written when it has content. The timestamped diff file remains gated by _hasNewDeployments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-latest.jsonpersistence from the_hasNewDeploymentsflag_hasNewDeploymentsstaysfalse, so_afterAll()never writes the JSON-latest.jsonis always written whenfinalJsonLatesthas content, ensuring the file is created on retry runs_hasNewDeployments(only written for actual new deployments)