promote: Phase 2 (tavle→board rename) from master to stable#804
Merged
Conversation
Mirror of the Phase 1 plugin pattern (PR #802) for the next noun in the opgave→event migration: rename the gRPC message types and RPC method names from Tavle to Board. Wire field names stay (`tavler`, `tavle_id`, `tavle_ids`) so generated C# accessors don't churn — only the type names and RPC method move. Concrete proto changes: - rpc ListTavler(ListTavlerRequest) returns (ListTavlerResponse) → rpc ListBoards(ListBoardsRequest) returns (ListBoardsResponse) - message Tavle → message Board - message ListTavlerRequest/Response → ListBoardsRequest/Response - Top-of-file comment updated to document Phase 2 boundaries. Concrete handler changes (EventsGrpcService.cs): - public override Task<ListTavlerResponse> ListTavler(...) → Task<ListBoardsResponse> ListBoards(...) - new Tavle { ... } → new Board { ... } - response.Tavler.Add(...) kept (generated from carved wire field) - All 15 generated accessors (request.TavleIds reads, event.TavleId setters) untouched — they're driven by carved wire fields. Build: dotnet clean + build green from eFormAPI.Web (0 errors, 10 pre-existing warnings). Backend restarts cleanly on :5000+:5001. Embedded copy at eform-angular-frontend/eFormAPI/Plugins/BackendConfiguration.Pn/ synced (diff -q silent). Spec: docs/superpowers/specs/2026-05-11-opgave-to-event-migration.md Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
feat(events): Phase 2 — rename gRPC tavle types to board
There was a problem hiding this comment.
Pull request overview
Promotes Phase 2 of the gRPC surface rename (tavle → board) from master to stable for the BackendConfiguration plugin, aligning the plugin’s gRPC API with the already-merged Flutter consumer changes and avoiding UNIMPLEMENTED calls in production.
Changes:
- Renames the gRPC RPC from
ListTavlertoListBoardsand updates request/response message types accordingly. - Renames the
Tavleproto message type toBoardwhile keeping wire field names (tavler,tavle_id, etc.) stable. - Updates the C# gRPC service handler to implement the renamed
ListBoardsRPC and returnBoardmessages.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eFormAPI/Plugins/BackendConfiguration.Pn/BackendConfiguration.Pn/Services/GrpcServices/EventsGrpcService.cs | Updates the gRPC service implementation to expose ListBoards and emit Board messages. |
| eFormAPI/Plugins/BackendConfiguration.Pn/BackendConfiguration.Pn/Protos/events.proto | Updates the gRPC schema to rename ListTavler* → ListBoards* and Tavle → Board, preserving wire field names. |
Comment on lines
33
to
37
| /// <summary> | ||
| /// gRPC adapter for the mobile "Opgaver" feature. | ||
| /// Read-only RPCs (ListEjendomme / ListTavler / ListOpgaver) reuse the existing | ||
| /// Read-only RPCs (ListEjendomme / ListBoards / ListOpgaver) reuse the existing | ||
| /// Properties + Calendar service paths and reshape the result into the | ||
| /// microting.opgaver wire contract. CompleteOpgave performs the SDK-case |
Comment on lines
+6
to
+8
| // `ejendom_id`) stay as-is so generated accessors don't churn; only | ||
| // message types and RPC method names move. Ejendom and rode renames | ||
| // land in follow-up phases. |
This was referenced May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotion PR: Phase 2 (tavle → board rename) was merged to `master` in #803 but I missed setting the base branch — it should have gone directly to `stable` per the plugin repo convention (the cycle skill explicitly notes this: "open PR ... toward `stable` for the plugin repo"). Phase 1's PR #802 correctly targeted `stable`; Phase 2's recovery is this fast-forward promotion.
Diff is exactly the Phase 2 changes: 1 source commit (`01694e27`) + 1 merge commit (`b84b5761`). Fast-forward is clean — `stable` has zero commits not on `master`.
Verification (carried forward from #803)
Coordinated rollout
🤖 Generated with Claude Code