Added DownloadInIterceptor import to the classes#1
Merged
yingbull merged 1 commit intoOct 31, 2024
Merged
Conversation
kateyang1998
commented
Oct 31, 2024
kateyang1998
commented
- oscarehr/integration/mcedt/DelegateFactory.java
- oscarehr/integration/mchcv/OnlineHCValidator.java
- oscarehr/integration/mcedt/DelegateFactory.java - oscarehr/integration/mchcv/OnlineHCValidator.java
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @kateyang1998 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
sebastian-j-ibanez
approved these changes
Oct 31, 2024
sebastian-j-ibanez
left a comment
sebastian-j-ibanez
left a comment
Collaborator
There was a problem hiding this comment.
Can confirm that these changes fix the compilation errors.
This was referenced Nov 7, 2024
Merged
Merged
sebastian-j-ibanez
pushed a commit
that referenced
this pull request
Dec 3, 2024
Add indexes to the measurements table
This was referenced Dec 13, 2024
Merged
Merged
Closed
Jdarji2130
pushed a commit
to Jdarji2130/Open-O-jay
that referenced
this pull request
Mar 23, 2025
Jdarji2130
pushed a commit
to Jdarji2130/Open-O-jay
that referenced
this pull request
Mar 23, 2025
…-indexes Add indexes to the measurements table
This was referenced Jul 16, 2025
Merged
Merged
This was referenced Aug 29, 2025
This was referenced Sep 23, 2025
This was referenced Sep 30, 2025
This was referenced Jan 18, 2026
This was referenced Jan 26, 2026
5 tasks
This was referenced Jan 28, 2026
LiamStanziani
added a commit
that referenced
this pull request
May 26, 2026
… encoding Addresses PR #225 review comment #1 (warrendennis): the previous PR removed Encode.forHtml(msg) at output because msg embedded intentional <span style='color:red'>NOT</span> markup. Concatenating raw request parameters (privilege, roleUserGroup, objectName from line 234) into an unencoded HTML body is XSS-prone — privilege in particular is built by scanning request parameter *names*, so an attacker URL like '?privilege<img src=x onerror=alert(1)>=foo' would land directly in msg. Replace the inline span markup with a CSS class on the alert wrapper (alert-danger / alert-info) driven by a msgIsError flag. Drop the redundant encodedRoleUserGroup / encodedObjectName helpers (they were a workaround for the missing output encoding) and restore Encode.forHtml(msg) at the display site. LogAction audit calls now use raw values consistently across all three flows — logs aren't HTML and shouldn't carry entities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.