chore: port TSQL PERIOD FOR SYSTEM_TIME for temporal tables (#4654)#2670
Merged
Conversation
## Summary - SQLFluff #4654 added the T-SQL `PERIOD FOR SYSTEM_TIME (start_col, end_col)` clause for temporal tables. Ported it to sqruff's `tsql.rs`: new `PeriodSegment` (reusing the existing `SyntaxKind::PeriodSegment`), wired into the `CreateTableStatementSegment` column/constraint list, with `PERIOD` and `SYSTEM_TIME` registered as unreserved keywords. - Added a minimal `temporal_tables` fixture (.sql + .yml) scoped to the PERIOD clause; the dialect test parses it with no unparsable segments. Parser-only change. Ported from SQLFluff 68aa104eda611833ba5b17a76cb1b3f334bea7d0 sqlfluff/sqlfluff#4654 sqlfluff/sqlfluff@68aa104
Contributor
Benchmark for 3aa7a17Click to view benchmark
|
This was referenced Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PERIOD FOR SYSTEM_TIME (start_col, end_col)clause for temporal tables. Ported it to sqruff'stsql.rs: newPeriodSegment(reusing the existingSyntaxKind::PeriodSegment), wired into theCreateTableStatementSegmentcolumn/constraint list, withPERIODandSYSTEM_TIMEregistered as unreserved keywords.temporal_tablesfixture (.sql + .yml) scoped to the PERIOD clause; the dialect test parses it with no unparsable segments. Parser-only change.Ported from SQLFluff 68aa104eda611833ba5b17a76cb1b3f334bea7d0
sqlfluff/sqlfluff#4654
sqlfluff/sqlfluff@68aa104