Draft
Conversation
upstream code has modernized the way its compiled extensions are built and imported. Changes include: - Build python extensions with cmake rather than building libraries and manually dlopening them. - Clean up imports throughout the codebase. Absolute imports of "so3g" are removed and replaced by relative imports from the internal submodules or from the compiled extension. Also clean up linter warnings. - Add a new github workflow that runs tests by building within a conda environment to get all dependencies and runs tests on a selection of python versions and linux/mac. - When building wheels, only build the 3 components of boost that we need. - After consultation with @mhasself and @BrianJKoopman, remove all docker support files that are no longer used. Encode the upstream version of spt3g directly in setup.py (rather than the Dockerfile).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream code has modernized the way its compiled extensions are built and imported. This work brings
so3gup to date with those changes:Build python extensions with cmake rather than building libraries and manually dlopening them.
Clean up imports throughout the codebase. Absolute imports of "so3g" are removed and replaced by relative imports from the internal submodules or from the compiled extension. Also clean up linter warnings.
Add a new github workflow that runs tests by building within a conda environment to get all dependencies and runs tests on a selection of python versions and linux/mac.
When building wheels, only build the 3 components of boost that we need.
After consultation with @mhasself and @BrianJKoopman, remove all docker support files that are no longer used. Encode the upstream version of spt3g directly in setup.py (rather than the Dockerfile).
This work supercedes #192, which will be closed.