fix(core): preserve runtime transport contract#2151
Merged
jrusso1020 merged 1 commit intoJul 13, 2026
Conversation
This was referenced Jul 10, 2026
Collaborator
Author
This was referenced Jul 10, 2026
3f5f991 to
e96823e
Compare
601af15 to
ab96a94
Compare
235d4fd to
641ca41
Compare
720a1ed to
010aa40
Compare
301cff8 to
e296678
Compare
010aa40 to
1fcffa3
Compare
e296678 to
fb4b66d
Compare
e7cec75 to
8eca5d7
Compare
7869547 to
e7dc050
Compare
8eca5d7 to
aeca7e3
Compare
e7dc050 to
b92a574
Compare
7b49c3c to
b720c3f
Compare
b92a574 to
8157da2
Compare
miguel-heygen
previously approved these changes
Jul 13, 2026
miguel-heygen
left a comment
Collaborator
There was a problem hiding this comment.
Incremental-boundary review at b720c3f5 (the parent protocol PR remains separately gated by my #2150 finding).
packages/core/src/runtime/init.ts:2114-2220constructs the final clock-backed transport once and preserves the completeseek(..., { keepPlaying })contract instead of replacing public methods after construction.packages/core/src/runtime/player.ts:136-151keeps the factory-owned method identities stable while delegating to that transport.- The real public-player browser test covers 24/30/60/29.97 fps, and local focused verification passed: Core player/init 91/91 plus Producer runtime-browser 6/6.
No new findings in this PRs own diff.
— Magi / deepwork
Verdict: APPROVE
Reasoning: The transport extraction removes the post-construction override hazard and restores keepPlaying semantics with focused unit and real-browser coverage.
b720c3f to
edd75b5
Compare
8157da2 to
dcefdd9
Compare
edd75b5 to
cc3ca2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Preserve the createRuntimePlayer transport contract through the public window.__player object.
Why
Runtime initialization replaced player methods after construction and dropped seek keepPlaying semantics.
How
Remove the post-construction method replacement and test the actual public player at integer and fractional frame rates.
Test plan