Skip to content

fix(core): preserve runtime transport contract#2151

Merged
jrusso1020 merged 1 commit into
mainfrom
07-10-fix_core_preserve_runtime_transport_contract
Jul 13, 2026
Merged

fix(core): preserve runtime transport contract#2151
jrusso1020 merged 1 commit into
mainfrom
07-10-fix_core_preserve_runtime_transport_contract

Conversation

@jrusso1020

@jrusso1020 jrusso1020 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

What

Preserve the createRuntimePlayer transport contract through the public window.__player object.

Why

Runtime initialization replaced player methods after construction and dropped seek keepPlaying semantics.

How

Remove the post-construction method replacement and test the actual public player at integer and fractional frame rates.

Test plan

  • core runtime player/init tests; producer runtime-browser contract
  • Stack-wide lint, format, build, typecheck, and relevant integration gates

jrusso1020 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jrusso1020 jrusso1020 force-pushed the 07-10-fix_player_version_runtime_protocol branch 2 times, most recently from 3f5f991 to e96823e Compare July 11, 2026 18:04
@jrusso1020 jrusso1020 force-pushed the 07-10-fix_core_preserve_runtime_transport_contract branch 2 times, most recently from 601af15 to ab96a94 Compare July 11, 2026 18:11
@jrusso1020 jrusso1020 force-pushed the 07-10-fix_player_version_runtime_protocol branch from 235d4fd to 641ca41 Compare July 11, 2026 18:16
@jrusso1020 jrusso1020 force-pushed the 07-10-fix_core_preserve_runtime_transport_contract branch 2 times, most recently from 720a1ed to 010aa40 Compare July 11, 2026 18:21
@jrusso1020 jrusso1020 force-pushed the 07-10-fix_player_version_runtime_protocol branch 2 times, most recently from 301cff8 to e296678 Compare July 12, 2026 04:01
@jrusso1020 jrusso1020 force-pushed the 07-10-fix_core_preserve_runtime_transport_contract branch from 010aa40 to 1fcffa3 Compare July 12, 2026 04:01
@jrusso1020 jrusso1020 force-pushed the 07-10-fix_player_version_runtime_protocol branch from e296678 to fb4b66d Compare July 12, 2026 04:32
@jrusso1020 jrusso1020 force-pushed the 07-10-fix_core_preserve_runtime_transport_contract branch 2 times, most recently from e7cec75 to 8eca5d7 Compare July 12, 2026 04:58
@jrusso1020 jrusso1020 force-pushed the 07-10-fix_player_version_runtime_protocol branch 2 times, most recently from 7869547 to e7dc050 Compare July 12, 2026 08:54
@jrusso1020 jrusso1020 force-pushed the 07-10-fix_core_preserve_runtime_transport_contract branch from 8eca5d7 to aeca7e3 Compare July 12, 2026 08:54
@jrusso1020 jrusso1020 force-pushed the 07-10-fix_player_version_runtime_protocol branch from e7dc050 to b92a574 Compare July 12, 2026 09:11
@jrusso1020 jrusso1020 force-pushed the 07-10-fix_core_preserve_runtime_transport_contract branch 2 times, most recently from 7b49c3c to b720c3f Compare July 13, 2026 15:52
@jrusso1020 jrusso1020 force-pushed the 07-10-fix_player_version_runtime_protocol branch from b92a574 to 8157da2 Compare July 13, 2026 15:52
miguel-heygen
miguel-heygen previously approved these changes Jul 13, 2026

@miguel-heygen miguel-heygen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incremental-boundary review at b720c3f5 (the parent protocol PR remains separately gated by my #2150 finding).

  • packages/core/src/runtime/init.ts:2114-2220 constructs the final clock-backed transport once and preserves the complete seek(..., { keepPlaying }) contract instead of replacing public methods after construction.
  • packages/core/src/runtime/player.ts:136-151 keeps the factory-owned method identities stable while delegating to that transport.
  • The real public-player browser test covers 24/30/60/29.97 fps, and local focused verification passed: Core player/init 91/91 plus Producer runtime-browser 6/6.

No new findings in this PRs own diff.

— Magi / deepwork

Verdict: APPROVE
Reasoning: The transport extraction removes the post-construction override hazard and restores keepPlaying semantics with focused unit and real-browser coverage.

@jrusso1020 jrusso1020 force-pushed the 07-10-fix_core_preserve_runtime_transport_contract branch from b720c3f to edd75b5 Compare July 13, 2026 17:29
@jrusso1020 jrusso1020 force-pushed the 07-10-fix_player_version_runtime_protocol branch from 8157da2 to dcefdd9 Compare July 13, 2026 17:29
@jrusso1020 jrusso1020 changed the base branch from 07-10-fix_player_version_runtime_protocol to graphite-base/2151 July 13, 2026 18:08
@jrusso1020 jrusso1020 force-pushed the 07-10-fix_core_preserve_runtime_transport_contract branch from edd75b5 to cc3ca2f Compare July 13, 2026 18:09
@jrusso1020 jrusso1020 changed the base branch from graphite-base/2151 to main July 13, 2026 18:09
@jrusso1020 jrusso1020 dismissed miguel-heygen’s stale review July 13, 2026 18:09

The base branch was changed.

@jrusso1020 jrusso1020 merged commit 242cb32 into main Jul 13, 2026
51 of 60 checks passed
@jrusso1020 jrusso1020 deleted the 07-10-fix_core_preserve_runtime_transport_contract branch July 13, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants