Skip to content

test(engine): isolate peer abort regression#2173

Open
jrusso1020 wants to merge 1 commit into
07-10-refactor-cli-decompose-render-phasesfrom
07-10-test-engine-isolate-peer-abort-regression
Open

test(engine): isolate peer abort regression#2173
jrusso1020 wants to merge 1 commit into
07-10-refactor-cli-decompose-render-phasesfrom
07-10-test-engine-isolate-peer-abort-regression

Conversation

@jrusso1020

@jrusso1020 jrusso1020 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

What

Isolate the engine peer-abort regression test from unrelated production dependency loading.

Why

The test used importOriginal for a large module graph, causing full-matrix timeouts that obscured the cancellation behavior it was meant to protect.

How

Replace the partial importOriginal mock with a complete minimal dependency mock and keep the assertion focused on aborting peer workers after the first fatal classified failure.

Test plan

  • Focused peer-abort regression
  • Complete Engine suite and non-Producer package matrix

This was referenced Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch 2 times, most recently from 209646d to b7cc5b6 Compare July 12, 2026 04:09
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch 2 times, most recently from 991430b to 807e86c Compare July 12, 2026 04:32
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch 4 times, most recently from ebedd1c to 9b7ce7b Compare July 12, 2026 09:05
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 4bf71a5 to 0946378 Compare July 12, 2026 09:11
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch 2 times, most recently from 1e281de to 1e31562 Compare July 13, 2026 15:52
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch 2 times, most recently from 24c93b9 to ee1e8fd Compare July 13, 2026 17:29
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch 2 times, most recently from 44473a8 to 996c416 Compare July 13, 2026 18:09
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from ee1e8fd to 31ebbda Compare July 13, 2026 18:09
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch from 996c416 to 665006e Compare July 13, 2026 18:35
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch 2 times, most recently from 3bd8775 to 841ca28 Compare July 13, 2026 20:27
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch 2 times, most recently from f57212b to eea1424 Compare July 13, 2026 20:33
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 841ca28 to 99291ad Compare July 13, 2026 20:33
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch from eea1424 to a66407f Compare July 13, 2026 22:09
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 260558c to f6dfed1 Compare July 13, 2026 22:18
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch from a66407f to 3f82ade Compare July 13, 2026 22:18
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from f6dfed1 to 50cf30c Compare July 13, 2026 23:08
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch from 3f82ade to 195ebe8 Compare July 13, 2026 23:08
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 50cf30c to a36d53c Compare July 14, 2026 00:03
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch from 195ebe8 to 7bc03fb Compare July 14, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant