fix(player): own connection and media resources

[jrusso1020]

What

Make Player connection resources symmetric and scope slideshow media ownership.

Why

Reconnect could retain destroyed handles, while slideshow operations scanned and mutated unrelated document media.

How

Null and recreate connection-owned resources idempotently and introduce an OwnedMediaRegistry with abortable cleanup.

Test plan

• Player reconnect, media-scope, slideshow, and owned-media registry tests
• Stack-wide lint, format, build, typecheck, and relevant integration gates

[jrusso1020]

• refactor(repo): resolve changed-code audit #2174
• test(engine): isolate peer abort regression #2173
• refactor(cli): decompose render phases #2172
• refactor(cli): centralize process lifecycle #2171
• fix(cloudrun): publish adapter contract #2170
• test(repo): execute packed subpaths #2169
• refactor(repo): centralize package subpaths #2168
• refactor(core): own edit protocol contract #2167
• test(compiler): enforce preview render parity #2166
• refactor(studio): gate SDK operation families #2165
• refactor(studio): gate Acorn writer migration #2164
• refactor(producer): make capture plans immutable #2163
• refactor(producer): unify render requests #2162
• refactor(engine): type capture failures #2161
• refactor(engine): manage child process lifecycles #2160
• refactor(engine): add fingerprinted browser leases #2159
• refactor(render): centralize execution ownership #2158
• refactor(core): unify composition contract #2157
• fix(studio): enforce optimistic file concurrency #2156
• fix(studio): make sdk cutover transactional #2155
• fix(render): publish artifacts atomically #2154
• fix(render): surface structured outcomes #2153
• fix(player): own connection and media resources #2152 👈 (View in Graphite)
• fix(core): preserve runtime transport contract #2151
• fix(player): version runtime protocol #2150
• test(repo): verify packed consumers #2149
• test(repo): enforce workspace contracts #2148
• fix(core): enforce strict runtime safety #2147
• test(producer): gate source tests by execution lane #2146
• fix(core): make timing masks safe for source loaders #2145
• chore(repo): forbid tracked generated artifacts #2144
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[james-russo-rames-d-jusso]

Clean ownership boundary — OwnedMediaRegistry replaces the fragile dataset.hfSlideshowMediaSync marker with AbortController-per-binding, and the 10-cycle reconnect test pins the idempotence contract cleanly. The el.ownerDocument.defaultView?.AbortController ?? AbortController fallback for cross-realm iframe media is a nice touch.

Nits

• packages/player/src/slideshow/hyperframes-slideshow.ts:1170 — stopDocumentMedia now stops only owned media, not document-wide. The name is left over from the old ownerDocument.querySelectorAll implementation. Consider stopOwnedMedia (or similar) to match the registry's actual scope. Trivial; ignore if you'd rather keep the internal API stable.
• packages/player/src/slideshow/hyperframes-slideshow.ts:1163-1174 — updateMutedState and stopDocumentMedia both call ownedMedia.sync(...) directly instead of routing through wireSlideshowMedia(). If a new element gets picked up by updateMutedState's call, its initial mute state is applied by the immediately-following setMuted(muted) (bounded set, single-threaded — safe), but the added-mute path from wireSlideshowMedia is duplicated. Consistent as-is; flagging in case you'd rather have one entry point.

What I didn't verify

• Cross-realm AbortController behavior in Firefox / older Safari — trusting the pattern generalizes to your target matrix.
• Whether any consumer outside packages/player relied on the old page-wide mute/pause semantics of <hyperframes-slideshow>. Workspace grep turned up none; the PR body explicitly calls the scope reduction a fix.

— Review by Rames D Jusso

[miguel-heygen]

Independent bottom-layer review on 16942c0c.

• Reconnect teardown/recreation is symmetric for controls and parent media (packages/player/src/hyperframes-player.ts:179, :192).
• The registry uses owner-realm AbortControllers and aborts removed/disconnected bindings (packages/player/src/slideshow/owned-media-registry.ts:35, :46, :67).
• Scope tests cover two slideshows plus unrelated page media (packages/player/src/slideshow/hyperframes-slideshow.test.ts:397).

Rames already covered the naming/entry-point nits; I found no additional correctness gap. Current required checks are green.

Verdict: APPROVE
Reasoning: Resource ownership is bounded to the component, teardown is deterministic, and reconnect/scope regressions are directly tested.

— Home

[jrusso1020]

Merge activity

• Jul 13, 8:14 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Jul 13, 8:15 PM UTC: @jrusso1020 merged this pull request with Graphite.

[miguel-heygen]

Re-reviewed the merged head 16942c0c12fab7e87876fa253432e29d85835db4. There is no new code delta since my approval, and the completed required checks are green. I found no post-merge correctness issue. The earlier naming / duplicate sync-entry-point notes remain optional cleanup only.

Verdict: COMMENT (post-merge: Ready)
Reasoning: Same approved head, green required CI, and no newly discovered blocker.
— Magi

[miguel-heygen]

Final freshness check on merged head 16942c0c12fab7e87876fa253432e29d85835db4.

The reviewed commit is unchanged, the player-ownership boundary remains clean, and the complete required check set is green. No post-merge regression or new review finding surfaced.

Verdict: COMMENT (post-merge ready)
Reasoning: The merged implementation remains sound and fully green; there is no actionable follow-up from this pass.

— Deepwork